fix: keep the nginx ingress annotations when the ingress controller is traefik #13

Merged
igor merged 1 commits from fix/traefik-keeps-nginx-annotations into main 2026-10-09 17:43:21 +00:00
Owner

Version 1.6.2.

ingress_annotations() treated the two ingress controllers as either/or: choosing traefik dropped the nginx proxy-body-size annotation, so on a cluster actually routed by nginx the 50 MiB upload cap silently became nginx' 1 MiB default and uploads failed with HTTP 413. An ingress annotation only acts when a controller of that family routes the ingress, so emit both annotation sets always: nginx's size and timeout annotations (plus the rewrite-target null that keeps API paths intact), and the Traefik middleware reference on top when the config says traefik. The Middleware object is created as before.

Version 1.6.2. `ingress_annotations()` treated the two ingress controllers as either/or: choosing traefik dropped the nginx `proxy-body-size` annotation, so on a cluster actually routed by nginx the 50 MiB upload cap silently became nginx' 1 MiB default and uploads failed with HTTP 413. An ingress annotation only acts when a controller of that family routes the ingress, so emit both annotation sets always: nginx's size and timeout annotations (plus the rewrite-target null that keeps API paths intact), and the Traefik middleware reference on top when the config says traefik. The Middleware object is created as before.
igor added 1 commit 2026-10-09 17:43:21 +00:00
ingress_annotations() treated the two controllers as either/or: choosing traefik dropped the nginx proxy-body-size annotation, so on a cluster routed by nginx the 50 MiB upload cap silently became nginx' 1 MiB default and uploads failed with HTTP 413. An ingress annotation only acts when a controller of that family routes the ingress, so emit both annotation sets always: nginx's size and timeout annotations (plus the rewrite-target null that keeps API paths intact), and the Traefik middleware reference on top when the config says traefik. The Middleware object is created as before.

Version 1.6.2.
igor merged commit ccc49ca7d1 into main 2026-10-09 17:43:21 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: public/supaspin#13